HomePhorge

Make differential revision ID parsing more robust

Description

Make differential revision ID parsing more robust

Summary:
If something that doesn't belong to any field appears in the commit message
below the differential revision field, it gets included as part of the
value for the field, which can mess up parsing.

Test Plan:
called differential.parsecommitmessage on a commit whose differential
revision field wasn't being parsed earlier (it had a line of dashes two
lines below the Differential Revision: line).

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4171

Details

Provenance
Nick HarperAuthored on Dec 12 2012, 5:43 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPcce5ebebe98b: Improve Drydock's ability to allocate leases correctly
Branches
Unknown
Tags
Unknown

Event Timeline