HomePhorge

Improve Differential handling of disabled users

Description

Improve Differential handling of disabled users

Summary:
We currently allow you to assign code review to disabled users, but
should not.

Test Plan:

  • Created revisions with no reviewers and only disabled reviewers, was

appropriately warned.

  • Looked at a disabled user handle link, was clearly informed.
  • Tried to create a new revision with a disabled reviewer, was rebuffed.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D1429

Details

Provenance
epriestleyAuthored on Jan 16 2012, 4:54 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4faab06c3c76: Enable herald rule for commits that need auditing
Branches
Loading...
Tags
Loading...

Event Timeline