HomePhorge

Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page

Description

Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15313

Test Plan:
Applied these three changes (with D25144, D25145, D25146, D25147, D25151,
D25152, D25153 on top).
Afterwards end up with the unresolved exception covered by T15263.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15313

Differential Revision: https://we.phorge.it/D25163

Details

Provenance
Andre KlapperAuthored on May 1 2023, 1:26 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4d88095f2a53: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Projects page…
Branches
Unknown
Tags
Unknown

Event Timeline