HomePhorge

Prevent "Maniphest Tasks" field from creating empty comment when revisions are

Description

Prevent "Maniphest Tasks" field from creating empty comment when revisions are
updated

Summary:

  • If you update a revision with a nonempty "Maniphest Tasks" field, an empty

comment is posted (see T586).

  • The transaction email currently says "Attached revision 'Unknown

Differential Revision'", move attaching to "didWriteRevision()" to make sure the
object has been written.

Test Plan: - Attached; updated a revision.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Maniphest Tasks: T685

Differential Revision: 1223

Details

Provenance
epriestleyAuthored on Dec 16 2011, 1:26 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP3cd92ab075c1: Minor fix to D1186 to enforce ordering.
Branches
Unknown
Tags
Unknown

Event Timeline