HomePhorge

Record lock timing information on PushEvents

Description

Record lock timing information on PushEvents

Summary:
Depends on D19249. Ref T13109. Add timing information to the PushEvent:

  • writeWait: Time spent waiting for a write lock.
  • readWait: Time spent waiting for a read lock.
  • hostWait: Roughly, total time spent on the leaf node.

The primary goal here is to see if readWait is meaningful in the wild. If it is, that motivates smarter routing, and the value of smarter routing can be demonstrated by looking for a reduction in read wait times.

Test Plan: Pushed some stuff, saw reasonable timing values in the table. Saw timing information in "Export Data".

Maniphest Tasks: T13109

Differential Revision: https://secure.phabricator.com/D19250

Details

Provenance
epriestleyAuthored on Mar 22 2018, 12:08 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP69bff489d4ec: Generate a random unique "Request ID" for SSH requests so processes can…
Branches
Unknown
Tags
Unknown

Event Timeline