HomePhorge

Fix the DarkConsole inline error log stack trace expansion behavior for Content…

Description

Fix the DarkConsole inline error log stack trace expansion behavior for Content-Security-Policy

Summary:
See PHI451. Ref T13102. DarkConsole uses an ancient inline "onclick" handler to expand the stack traces for errors.

The new Content-Security-Policy prevents this from functioning.

Replace this with a more modern behavior-driven action instead.

Test Plan:

  • Clicked some errors in DarkConsole, saw stack traces appear.
  • Grepped for onclick and jsprintf() to see if I could find any more of these, but came up empty.

Maniphest Tasks: T13102

Differential Revision: https://secure.phabricator.com/D19218

Details

Provenance
epriestleyAuthored on Mar 13 2018, 4:26 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPdfd8b0225b3d: Add a UI element for reviewing older generations of Harbormaster builds
Branches
Unknown
Tags
Unknown

Event Timeline