HomePhorge

Fix error in Mercurial when no offset is specified

Description

Fix error in Mercurial when no offset is specified

Summary:
When viewing the history of a Mercurial diffusion repository the server return a 500. This is
because a function call to array_slice requires the offset to be set to an integer. So when it is
not specified it can be set to 0 as a default.

The error is as follows:

ERROR 8192: array_slice(): Passing null to parameter #2 ($offset) of type int is deprecated at [/usr/local/www/phorge/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:167]; PHP message: arcanist(head=master, ref.master=3cb117684f4e), phorge(head=master, ref.master=4bf5c452eb28); PHP message:   #0 array_slice(array, NULL) called at [<phorge>/src/applications/diffusion/conduit/DiffusionHistoryQueryConduitAPIMethod.php:167]

Test Plan: The history tab should not return a 500 when not specifying an offset

Reviewers: O1 Blessed Committers, valerio.bozzolan, speck

Reviewed By: O1 Blessed Committers, valerio.bozzolan, speck

Subscribers: aklapper, speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25673

Details

Provenance
Andre KlapperAuthored on Sep 4 2024, 5:45 AM
Jeffrey GelensCommitted on Dec 11 2024, 3:02 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP7429da91d293: Repository Identity "Automatically Detected User": don't trust unverified emails
Branches
Unknown
Tags
Unknown

Event Timeline