HomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page

Description

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conduit page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15307

Test Plan:
Applied these two changes (on top D25144, D25145, D25146, D25147, D25150,
D25151, D25152, D25153, D25154 locally applied) and /conduit/ finally
rendered in web browser. Also the page /conduit/query/.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15307

Differential Revision: https://we.phorge.it/D25156

Details

Provenance
Andre KlapperAuthored on Apr 30 2023, 9:27 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPe65ac7b8800d: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Conpherence page
Branches
Loading...
Tags
Loading...

Event Timeline