HomePhorge

Return HTTP 500, not HTTP 200, on exception pages

Description

Return HTTP 500, not HTTP 200, on exception pages

Summary: Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan: Added a fake throw new Exception() and verified I got an HTTP 500 response.

Reviewers: jamesr, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4064

Differential Revision: https://secure.phabricator.com/D7507

Details

Provenance
epriestleyAuthored on Nov 5 2013, 3:25 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPce48375951bd: Don't throw when user tries to use an empty password via HTTP auth
Branches
Unknown
Tags
Unknown

Event Timeline