HomePhorge

Add Disabled mode to landing revision ui

Description

Add Disabled mode to landing revision ui

Summary:
Fixes T4066.

add isActionDisabled() to DifferentialLandingStrategy, which also explains why it is so.
Make an appropriate pop-up in the controller.

Also make the whole UI "workflow", and convert createMenuItems() to createMenuItem() (Singular).

Test Plan: Click "Land to..." button in all kinds of revisions.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4066

Differential Revision: https://secure.phabricator.com/D8105

Details

Provenance
Aviv EyalAuthored on Jan 30 2014, 9:07 AM
epriestleyCommitted on Jan 30 2014, 9:07 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP6b4998bf4beb: Increment copyright year and add 2017 dates to calendar import script
Branches
Unknown
Tags
Unknown

Event Timeline