HomePhorge
Diffusion Phorge d0af617818b6

Add "final" to (almost) everything else
d0af617818b6
Actions

Description

Add "final" to (almost) everything else

Summary: Last of the big final patches. Left a few debatable classes (12 out of about 400) that I'll deal with individually eventually.

Test Plan: Ran testEverythingImplemented.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1881

Details

Provenance
epriestleyAuthored on Mar 13 2012, 4:21 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP7c9057854b4b: [svn1.7] Fix thrown exception when browsing diffusion with added directories
Branches
Unknown
Tags
Unknown

Event Timeline

Changes (182)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.
PathSize
src/
applications/
base/
storage/
configuration/
conduit/
storage/
methodcalllog/
herald/
adapter/
commit/
differential/
dryrun/
config/
action/
condition/
contenttype/
field/
repetitionpolicy/
ruletype/
valuetype/
engine/
effect/
engine/
exception/
storage/
action/
condition/
edithistory/
rule/
transcript/
apply/
base/
condition/
object/
rule/
maniphest/
auxiliaryfield/
typeexception/
validationexception/
constants/
action/
base/
editor/
transaction/
replyhandler/
storage/
auxiliary/
base/
task/
transaction/
view/
tasklist/
tasksummary/
transactiondetail/
transactionlist/
metamta/
adapter/
amazonses/
phpmailerlite/
sendgrid/
test/
storage/
mail/
__tests__/
mailinglist/
receivedmail/
owners/
query/
path/
storage/
owner/
package/
path/
paste/
storage/
paste/
people/
storage/
log/
preferences/
profile/
user/
useroauthinfo/
usersshkey/
phid/
handle/
const/
status/
data/
view/
selector/
storage/
base/
phid/
phriction/
constants/
action/
storage/
content/
document/
__tests__/
project/
storage/
affiliation/
base/
profile/
project/
transaction/
repository/
daemon/
commitdiscovery/
git/
mercurial/
svn/
committask/
parser/
default/
storage/
arcanistproject/
base/
commit/
commitdata/
repository/
shortcut/
symbol/
worker/
commitchangeparser/
git/
mercurial/
commitmessageparser/
git/
mercurial/
svn/
herald/
owner/
search/
index/
indexer/
differential/
maniphest/
phriction/
repository/
user/
storage/
document/
document/
field/
relationship/
slowvote/
storage/
base/
choice/
comment/
option/
poll/
uiexample/
examples/
client/
listfilter/
pager/
reactor/
xhpastview/
storage/
parsetree/
infrastructure/
daemon/
garbagecollector/
irc/
handler/
differentialnotification/
objectname/
protocol/
storage/
event/
log/
timeline/
cursor/
iterator/
storage/
base/
cursor/
event/
eventdata/
workers/
storage/
task/
taskdata/
taskmaster/
worker/
goodfornothing/
events/
engine/
lint/
engine/
hook/
xhpastsymbolname/
linter/
javelin/
markup/
remarkup/
markuprule/
differential/
diffusion/
embedobject/
imagemacro/
maniphest/
mention/
paste/
phriction/
proxyimage/
youtube/
setup/
testing/
testcase/
__tests__/
storage/
connection/
isolated/
__tests__/
mysql/
exception/
accessdenied/
base/
connection/
connectionlost/
count/
duplicatekey/
objectmissing/
parameter/
recoverable/
lisk/
dao/
__tests__/
view/
control/
objectselector/
table/
tokenizer/
typeahead/
dialog/
form/
control/
checkbox/
divider/
draganddropupload/
file/
markup/
password/
recaptcha/
select/
static/
submit/
text/
textarea/
togglebuttons/
tokenizer/
javelin-view/
page/
base/
standard/
widget/
keyboardshortcuts/

rPd0af617818b6

View Options

src/applications/base/storage/configuration/DatabaseConfigurationProvider.php

View Options

src/applications/conduit/storage/methodcalllog/PhabricatorConduitMethodCallLog.php

View Options

src/applications/herald/adapter/commit/HeraldCommitAdapter.php

View Options

src/applications/herald/adapter/differential/HeraldDifferentialRevisionAdapter.php

View Options

src/applications/herald/adapter/dryrun/HeraldDryRunAdapter.php

View Options

src/applications/herald/config/action/HeraldActionConfig.php

View Options

src/applications/herald/config/condition/HeraldConditionConfig.php

View Options

src/applications/herald/config/contenttype/HeraldContentTypeConfig.php

View Options

src/applications/herald/config/field/HeraldFieldConfig.php

View Options

src/applications/herald/config/repetitionpolicy/HeraldRepetitionPolicyConfig.php

View Options

src/applications/herald/config/ruletype/HeraldRuleTypeConfig.php

View Options

src/applications/herald/config/valuetype/HeraldValueTypeConfig.php

View Options

src/applications/herald/engine/effect/HeraldEffect.php

View Options

src/applications/herald/engine/engine/HeraldEngine.php

View Options

src/applications/herald/engine/engine/exception/HeraldInvalidConditionException.php

View Options

src/applications/herald/engine/engine/exception/HeraldInvalidFieldException.php

View Options

src/applications/herald/engine/engine/exception/HeraldRecursiveConditionsException.php

View Options

src/applications/herald/storage/action/HeraldAction.php

View Options

src/applications/herald/storage/condition/HeraldCondition.php

View Options

src/applications/herald/storage/edithistory/HeraldRuleEdit.php

View Options

src/applications/herald/storage/rule/HeraldRule.php

View Options

src/applications/herald/storage/transcript/apply/HeraldApplyTranscript.php

View Options

src/applications/herald/storage/transcript/base/HeraldTranscript.php

View Options

src/applications/herald/storage/transcript/condition/HeraldConditionTranscript.php

View Options

src/applications/herald/storage/transcript/object/HeraldObjectTranscript.php

View Options

src/applications/herald/storage/transcript/rule/HeraldRuleTranscript.php

View Options

src/applications/maniphest/auxiliaryfield/typeexception/ManiphestAuxiliaryFieldTypeException.php

View Options

src/applications/maniphest/auxiliaryfield/validationexception/ManiphestAuxiliaryFieldValidationException.php

View Options

src/applications/maniphest/constants/action/ManiphestAction.php

View Options

src/applications/maniphest/constants/base/ManiphestConstants.php

View Options

src/applications/maniphest/editor/transaction/ManiphestTransactionEditor.php

View Options

src/applications/maniphest/replyhandler/ManiphestReplyHandler.php

View Options

src/applications/maniphest/storage/auxiliary/ManiphestTaskAuxiliaryStorage.php

View Options

src/applications/maniphest/storage/base/ManiphestDAO.php

View Options

src/applications/maniphest/storage/task/ManiphestTask.php

View Options

src/applications/maniphest/storage/transaction/ManiphestTransaction.php

View Options

src/applications/maniphest/view/tasklist/ManiphestTaskListView.php

View Options

src/applications/maniphest/view/tasksummary/ManiphestTaskSummaryView.php

View Options

src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php

View Options

src/applications/maniphest/view/transactionlist/ManiphestTransactionListView.php

View Options

src/applications/metamta/adapter/amazonses/PhabricatorMailImplementationAmazonSESAdapter.php

View Options

src/applications/metamta/adapter/phpmailerlite/PhabricatorMailImplementationPHPMailerLiteAdapter.php

View Options

src/applications/metamta/adapter/sendgrid/PhabricatorMailImplementationSendGridAdapter.php

View Options

src/applications/metamta/adapter/test/PhabricatorMailImplementationTestAdapter.php

View Options

src/applications/metamta/storage/mail/PhabricatorMetaMTAAttachment.php

View Options

src/applications/metamta/storage/mail/PhabricatorMetaMTAMail.php

View Options

src/applications/metamta/storage/mail/__tests__/PhabricatorMetaMTAMailTestCase.php

View Options

src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php

View Options

src/applications/metamta/storage/receivedmail/PhabricatorMetaMTAReceivedMail.php

View Options

src/applications/owners/query/path/PhabricatorOwnerPathQuery.php

View Options

src/applications/owners/storage/owner/PhabricatorOwnersOwner.php

View Options

src/applications/owners/storage/package/PhabricatorOwnersPackage.php

View Options

src/applications/owners/storage/path/PhabricatorOwnersPath.php

View Options

src/applications/paste/storage/paste/PhabricatorPaste.php

View Options

src/applications/people/storage/log/PhabricatorUserLog.php

View Options

src/applications/people/storage/preferences/PhabricatorUserPreferences.php

View Options

src/applications/people/storage/profile/PhabricatorUserProfile.php

View Options

src/applications/people/storage/user/PhabricatorUser.php

View Options

src/applications/people/storage/useroauthinfo/PhabricatorUserOAuthInfo.php

View Options

src/applications/people/storage/usersshkey/PhabricatorUserSSHKey.php

View Options

src/applications/phid/handle/PhabricatorObjectHandle.php

View Options

src/applications/phid/handle/const/status/PhabricatorObjectHandleStatus.php

View Options

src/applications/phid/handle/data/PhabricatorObjectHandleData.php

View Options

src/applications/phid/handle/view/selector/PhabricatorHandleObjectSelectorDataView.php

View Options

src/applications/phid/storage/base/PhabricatorPHIDDAO.php

View Options

src/applications/phid/storage/phid/PhabricatorPHID.php

View Options

src/applications/phriction/constants/action/PhrictionActionConstants.php

View Options

src/applications/phriction/storage/content/PhrictionContent.php

View Options

src/applications/phriction/storage/document/PhrictionDocument.php

View Options

src/applications/phriction/storage/document/__tests__/PhrictionDocumentTestCase.php

View Options

src/applications/project/storage/affiliation/PhabricatorProjectAffiliation.php

View Options

src/applications/project/storage/base/PhabricatorProjectDAO.php

View Options

src/applications/project/storage/profile/PhabricatorProjectProfile.php

View Options

src/applications/project/storage/project/PhabricatorProject.php

View Options

src/applications/project/storage/transaction/PhabricatorProjectTransaction.php

View Options

src/applications/repository/daemon/commitdiscovery/git/PhabricatorRepositoryGitCommitDiscoveryDaemon.php

View Options

src/applications/repository/daemon/commitdiscovery/mercurial/PhabricatorRepositoryMercurialCommitDiscoveryDaemon.php

View Options

src/applications/repository/daemon/commitdiscovery/svn/PhabricatorRepositorySvnCommitDiscoveryDaemon.php

View Options

src/applications/repository/daemon/committask/PhabricatorRepositoryCommitTaskDaemon.php

View Options

src/applications/repository/parser/default/PhabricatorRepositoryDefaultCommitMessageDetailParser.php

View Options

src/applications/repository/storage/arcanistproject/PhabricatorRepositoryArcanistProject.php

View Options

src/applications/repository/storage/base/PhabricatorRepositoryDAO.php

View Options

src/applications/repository/storage/commit/PhabricatorRepositoryCommit.php

View Options

src/applications/repository/storage/commitdata/PhabricatorRepositoryCommitData.php

View Options

src/applications/repository/storage/repository/PhabricatorRepository.php

View Options

src/applications/repository/storage/shortcut/PhabricatorRepositoryShortcut.php

View Options

src/applications/repository/storage/symbol/PhabricatorRepositorySymbol.php

View Options

src/applications/repository/worker/commitchangeparser/git/PhabricatorRepositoryGitCommitChangeParserWorker.php

View Options

src/applications/repository/worker/commitchangeparser/mercurial/PhabricatorRepositoryMercurialCommitChangeParserWorker.php

View Options

src/applications/repository/worker/commitmessageparser/git/PhabricatorRepositoryGitCommitMessageParserWorker.php

View Options

src/applications/repository/worker/commitmessageparser/mercurial/PhabricatorRepositoryMercurialCommitMessageParserWorker.php

View Options

src/applications/repository/worker/commitmessageparser/svn/PhabricatorRepositorySvnCommitMessageParserWorker.php

View Options

src/applications/repository/worker/herald/PhabricatorRepositoryCommitHeraldWorker.php

View Options

src/applications/repository/worker/owner/PhabricatorRepositoryCommitOwnersWorker.php

View Options

src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php

View Options

src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php

View Options

src/applications/search/index/indexer/phriction/PhabricatorSearchPhrictionIndexer.php

View Options

src/applications/search/index/indexer/repository/PhabricatorSearchCommitIndexer.php

View Options

src/applications/search/index/indexer/user/PhabricatorSearchUserIndexer.php

View Options

src/applications/search/storage/document/document/PhabricatorSearchDocument.php

View Options

src/applications/search/storage/document/field/PhabricatorSearchDocumentField.php

View Options

src/applications/search/storage/document/relationship/PhabricatorSearchDocumentRelationship.php

View Options

src/applications/slowvote/storage/base/PhabricatorSlowvoteDAO.php

View Options

src/applications/slowvote/storage/choice/PhabricatorSlowvoteChoice.php

View Options

src/applications/slowvote/storage/comment/PhabricatorSlowvoteComment.php

View Options

src/applications/slowvote/storage/option/PhabricatorSlowvoteOption.php

View Options

src/applications/slowvote/storage/poll/PhabricatorSlowvotePoll.php

View Options

src/applications/uiexample/examples/client/JavelinViewExample.php

View Options

src/applications/uiexample/examples/client/JavelinViewExampleServerView.php

View Options

src/applications/uiexample/examples/listfilter/PhabricatorUIListFilterExample.php

View Options

src/applications/uiexample/examples/pager/PhabricatorUIPagerExample.php

View Options

src/applications/uiexample/examples/reactor/JavelinReactorExample.php

View Options

src/applications/xhpastview/storage/parsetree/PhabricatorXHPASTViewParseTree.php

View Options

src/infrastructure/daemon/garbagecollector/PhabricatorGarbageCollectorDaemon.php

View Options

src/infrastructure/daemon/irc/handler/differentialnotification/PhabricatorIRCDifferentialNotificationHandler.php

View Options

src/infrastructure/daemon/irc/handler/objectname/PhabricatorIRCObjectNameHandler.php

View Options

src/infrastructure/daemon/irc/handler/protocol/PhabricatorIRCProtocolHandler.php

View Options

src/infrastructure/daemon/storage/event/PhabricatorDaemonLogEvent.php

View Options

src/infrastructure/daemon/storage/log/PhabricatorDaemonLog.php

View Options

src/infrastructure/daemon/timeline/cursor/iterator/PhabricatorTimelineIterator.php

View Options

src/infrastructure/daemon/timeline/storage/base/PhabricatorTimelineDAO.php

View Options

src/infrastructure/daemon/timeline/storage/cursor/PhabricatorTimelineCursor.php

View Options

src/infrastructure/daemon/timeline/storage/event/PhabricatorTimelineEvent.php

View Options

src/infrastructure/daemon/timeline/storage/eventdata/PhabricatorTimelineEventData.php

View Options

src/infrastructure/daemon/workers/storage/task/PhabricatorWorkerTask.php

View Options

src/infrastructure/daemon/workers/storage/taskdata/PhabricatorWorkerTaskData.php

View Options

src/infrastructure/daemon/workers/taskmaster/PhabricatorTaskmasterDaemon.php

View Options

src/infrastructure/daemon/workers/worker/goodfornothing/PhabricatorGoodForNothingWorker.php

View Options

src/infrastructure/events/engine/PhabricatorEventEngine.php

View Options

src/infrastructure/lint/engine/PhabricatorLintEngine.php

View Options

src/infrastructure/lint/hook/xhpastsymbolname/PhabricatorSymbolNameLinter.php

View Options

src/infrastructure/lint/linter/javelin/PhabricatorJavelinLinter.php

View Options

src/infrastructure/markup/remarkup/markuprule/differential/PhabricatorRemarkupRuleDifferential.php

View Options

src/infrastructure/markup/remarkup/markuprule/diffusion/PhabricatorRemarkupRuleDiffusion.php

View Options

src/infrastructure/markup/remarkup/markuprule/embedobject/PhabricatorRemarkupRuleEmbedFile.php

View Options

src/infrastructure/markup/remarkup/markuprule/imagemacro/PhabricatorRemarkupRuleImageMacro.php

View Options

src/infrastructure/markup/remarkup/markuprule/maniphest/PhabricatorRemarkupRuleManiphest.php

View Options

src/infrastructure/markup/remarkup/markuprule/mention/PhabricatorRemarkupRuleMention.php

View Options

src/infrastructure/markup/remarkup/markuprule/paste/PhabricatorRemarkupRulePaste.php

View Options

src/infrastructure/markup/remarkup/markuprule/phriction/PhabricatorRemarkupRulePhriction.php

View Options

src/infrastructure/markup/remarkup/markuprule/proxyimage/PhabricatorRemarkupRuleProxyImage.php

View Options

src/infrastructure/markup/remarkup/markuprule/youtube/PhabricatorRemarkupRuleYoutube.php

View Options

src/infrastructure/setup/PhabricatorSetup.php

View Options

src/infrastructure/testing/testcase/__tests__/PhabricatorTrivialTestCase.php

View Options

src/storage/connection/isolated/AphrontIsolatedDatabaseConnection.php

View Options

src/storage/connection/isolated/__tests__/AphrontIsolatedDatabaseConnectionTestCase.php

View Options

src/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

View Options

src/storage/exception/accessdenied/AphrontQueryAccessDeniedException.php

View Options

src/storage/exception/base/AphrontQueryException.php

View Options

src/storage/exception/connection/AphrontQueryConnectionException.php

View Options

src/storage/exception/connectionlost/AphrontQueryConnectionLostException.php

View Options

src/storage/exception/count/AphrontQueryCountException.php

View Options

src/storage/exception/duplicatekey/AphrontQueryDuplicateKeyException.php

View Options

src/storage/exception/objectmissing/AphrontQueryObjectMissingException.php

View Options

src/storage/exception/parameter/AphrontQueryParameterException.php

View Options

src/storage/exception/recoverable/AphrontQueryRecoverableException.php

View Options

src/storage/lisk/dao/__tests__/LiskIsolationTestCase.php

View Options

src/storage/lisk/dao/__tests__/LiskIsolationTestDAO.php

View Options

src/storage/lisk/dao/__tests__/LiskIsolationTestDAOException.php

View Options

src/view/control/objectselector/PhabricatorObjectSelectorDialog.php

View Options

src/view/control/table/AphrontTableView.php

View Options

src/view/control/tokenizer/AphrontTokenizerTemplateView.php

View Options

src/view/control/typeahead/AphrontTypeaheadTemplateView.php

View Options

src/view/dialog/AphrontDialogView.php

View Options

src/view/form/control/checkbox/AphrontFormCheckboxControl.php

View Options

src/view/form/control/divider/AphrontFormDividerControl.php

View Options

src/view/form/control/draganddropupload/AphrontFormDragAndDropUploadControl.php

View Options

src/view/form/control/file/AphrontFormFileControl.php

View Options

src/view/form/control/markup/AphrontFormMarkupControl.php

View Options

src/view/form/control/password/AphrontFormPasswordControl.php

View Options

src/view/form/control/recaptcha/AphrontFormRecaptchaControl.php

View Options

src/view/form/control/select/AphrontFormSelectControl.php

View Options

src/view/form/control/static/AphrontFormStaticControl.php

View Options

src/view/form/control/submit/AphrontFormSubmitControl.php

View Options

src/view/form/control/text/AphrontFormTextControl.php

View Options

src/view/form/control/textarea/AphrontFormTextAreaControl.php

View Options

src/view/form/control/togglebuttons/AphrontFormToggleButtonsControl.php

View Options

src/view/form/control/tokenizer/AphrontFormTokenizerControl.php

View Options

src/view/javelin-view/AphrontJavelinView.php

View Options

src/view/page/base/AphrontPageView.php

View Options

src/view/page/standard/PhabricatorStandardPageView.php

View Options

src/view/widget/keyboardshortcuts/AphrontKeyboardShortcutsAvailableView.php