HomePhorge

Break AphrontWriteGuard dependency on AphrontRequest

Description

Break AphrontWriteGuard dependency on AphrontRequest

Summary:
I want to move queryfx() and family to libphutil, for @chad and others (see T1283). We need to break a few dependencies to do this.

Since AphrontWriteGuard is independently useful, I broke the dependency between it and AphrontRequest rather than between Connection and WriteGuard. I'll move its implementation to libphutil in a future diff.

Test Plan: Loaded site, submitted CSRF form successfully, monkeyed with CSRF token, submitted CSRF form, got error.

Reviewers: btrahan, vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T1283

Differential Revision: https://secure.phabricator.com/D3042

Details

Provenance
epriestleyAuthored on Jul 23 2012, 3:17 PM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP8213a70f3d68: Fix "fullName" rules for Maniphest transaction email
Branches
Unknown
Tags
Unknown

Event Timeline