HomePhorge

Use exceptions for S3 error messages

Description

Use exceptions for S3 error messages

Summary:
Right now, the "SimpleEmailService" class uses trigger_error() to communicate
error messages. This means they get lost in the error logs and aren't visible in
the MetaMTA interface.

Provide a flag to strengthen them into exceptions, instead.

(I've attempted to emulate the prevailing style so I can offer this upstream.)

Test Plan: Faked an error condition and got a detailed stack trace in MetaMTA
instead of an empty "Message" field.
Reviewed By: jungejason
Reviewers: hunterbridges, codeblock, jungejason, tuomaspelkonen, aran
CC: aran, jungejason
Differential Revision: 783

Details

Provenance
epriestleyAuthored on Aug 4 2011, 8:09 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPc7e1fa626d75: Fix typo in Celerity mapper
Branches
Loading...
Tags
Loading...

Event Timeline