HomePhorge

When editing a tab panel from a dashboard, redirect back to the dashboard

Description

When editing a tab panel from a dashboard, redirect back to the dashboard

Summary:
Depends on D20396. Ref T13272. Currently, using the dropdowns to edit a tab panel from a dashboard redirects you to the tab panel page.

Instead, redirect back to the context page (usually, a dashboard -- but theoretically a containing tab panel, since you can put tab panels inside tab panels).

Also, fix some JS issues with non-integer panel keys. I've moved panel keys from "0, 1, 2, ..." to having arbitrary keys to make some operations less flimsy/error-prone, but this needs some JS tweaks.

Test Plan: Edited a tab panel from a dashboard, got sent sensibly back to the dashboard.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272

Differential Revision: https://secure.phabricator.com/D20397

Details

Provenance
epriestleyAuthored on Apr 11 2019, 9:13 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP9ad9ac9be695: On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown…
Branches
Unknown
Tags
Unknown

Event Timeline