HomePhorge

Straighten out replication/cache behavior in "bin/storage dump"

Description

Straighten out replication/cache behavior in "bin/storage dump"

Summary:
Fixes T13336.

  • Prevent --no-indexes from being combined with --for-replica, since combining these options can only lead to heartbreak.
  • In --for-replica mode, dump caches too. See discussion in T13336. It is probably "safe" to not dump these today, but fragile and not correct.
  • Mark the "MarkupCache" table as having "Cache" persistence, not "Data" persistence (no need to back it up, since it can be fully regenerated from other datasources).

Test Plan: Ran bin/storage dump with various combinations of flags.

Maniphest Tasks: T13336

Differential Revision: https://secure.phabricator.com/D20743

Details

Provenance
epriestleyAuthored on Aug 28 2019, 7:34 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP0943561dcb78: Fix incorrect construction of subtype map when validating "subtype"…
Branches
Loading...
Tags
Loading...

Event Timeline