HomePhorge

Fix double-stops on profiler sampling

Description

Fix double-stops on profiler sampling

Summary:
For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile.

Instead, keep track of whether it is running or not, and don't stop it a second time.

Ref T2870.

Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate.

Reviewers: btrahan, chad

CC: aran

Maniphest Tasks: T2870

Differential Revision: https://secure.phabricator.com/D5534

Details

Provenance
epriestleyAuthored on Apr 2 2013, 6:26 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPcde1416446f6: Guarantee the existence of the Phabricator access log
Branches
Unknown
Tags
Unknown

Event Timeline