HomePhorge

Don't try to implicitly subscribe users who are already subscribed

Description

Don't try to implicitly subscribe users who are already subscribed

Summary:
Fixes T2587. Specifically:

  • Don't try to implicitly subscribe the actor if they're already subscribed.
  • Since there are like 5 things that need to interact with subscribers, just load them once upfront for Subscribable objects.

Test Plan: Made a comment on a mock I was CC'd on without an error.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2587

Differential Revision: https://secure.phabricator.com/D5091

Details

Provenance
epriestleyAuthored on Feb 22 2013, 3:54 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPcebe6ac38771: Stylize bubble counts.
Branches
Unknown
Tags
Unknown

Event Timeline