HomePhorge

Continue replacing Commit/Audit status checks with object-based checks

Description

Continue replacing Commit/Audit status checks with object-based checks

Summary: Ref T13195. See PHI851. Continuing down the path toward replacing these legacy numeric constants with more modern string constants.

Test Plan:

  • Raised concern, requested verification, verified.
  • Looked at commit hovercard with audit status.
  • Viewed header on a commit page.
  • (Didn't test the Doorkeeper stuff since it requires linking to Asana and seems unlikely to break.)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13195

Differential Revision: https://secure.phabricator.com/D19647

Details

Provenance
epriestleyAuthored on Sep 7 2018, 9:01 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP6dc721009d9e: Layout Phriction actions without floats, to avoid conflicts with floating…
Branches
Unknown
Tags
Unknown

Event Timeline