HomePhorge

Drag & Drop: set a link as external

Description

Drag & Drop: set a link as external

Summary:
Rest assured: external links remain evil, by default.

Don't adopt them randomly by induction.

Whether you believe it or not, this specific external
link merited some deep thoughts on Phorge:

So, whenever you use a mouse, a finger, or whenever we have
a confirmation dialog or not to prevent onblur disasters,
this change is probably consistent with common expectations.

Having said, external links remain evil - by default.

Closes T15172

Test Plan:

  • Drag & Drop a File on a Remarkup text
  • click on the link inside the popup
  • it opens in a new tab (without risk of form loss)

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15172

Differential Revision: https://we.phorge.it/D25077

Details

Provenance
Valerio BozzolanAuthored on Mar 17 2023, 5:13 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP4f356838beda: FileUpload: show File page instead of binary file
Branches
Unknown
Tags
Unknown

Event Timeline