HomePhorge

Correctly handle downloading ZIP with empty directories in Phragment

Description

Correctly handle downloading ZIP with empty directories in Phragment

Summary: This logic causes an exception because getPHID() is called on a fragment that has no latest version. This fixes the code so that in this scenario, it returns an empty array (with no path to be added to the ZIP).

Test Plan: Downloaded the ZIP successfully after the patch was applied.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4205

Differential Revision: https://secure.phabricator.com/D7735

Details

Provenance
James RhodesAuthored on Dec 7 2013, 5:15 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPc48cfb31bc76: Implement viewing versions and downloading patches in Phragment
Branches
Unknown
Tags
Unknown

Event Timeline