HomePhorge

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()

Description

Fix incorrect return value of PhabricatorCustomField::readValueFromObject()

Summary:
PhabricatorCustomField::readValueFromObject() returns $this while none of its seven child class implementations returns any value.
Make the method return nothing to make PHPStan a bit happier.

Closes T15895

Test Plan: Run static code analysis; read/grep the codebase.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15895

Differential Revision: https://we.phorge.it/D25751

Details

Provenance
Andre KlapperAuthored on Jul 28 2024, 7:43 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID()
Branches
Unknown
Tags
Unknown

Event Timeline