HomePhorge

Mark the "Reviewer" field for Commits as deprecated

Description

Mark the "Reviewer" field for Commits as deprecated

Summary:
Depends on D18931. Ref T13048. Ref T13041. This field means "the first accepting reviewer, where order is mostly arbitrary". Modern rules should almost certainly use "Accepting Reviewers" instead.

Getting rid of this completely is a pain, but we can at least reduce confusion by marking it as not-the-new-hotness. Add a "Deprecated" group, move it there, and mark it for exile.

Test Plan:
Edited a commit rule, saw it in "Deprecated" group at the bottom of the list:

{F5395001}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048, T13041

Differential Revision: https://secure.phabricator.com/D18932

Details

Provenance
epriestleyAuthored on Jan 25 2018, 10:25 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP5c762d895796: Document the new "only if this didn't match last time" Herald action setting
Branches
Unknown
Tags
Unknown

Event Timeline