HomePhorge

Fix PHP 8.1 "strlen(null)" exception which blocks editing a Dashboard Tab Panel

Description

Fix PHP 8.1 "strlen(null)" exception which blocks editing a Dashboard Tab Panel

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15345

Test Plan: After applying this change, the "Edit Panel" page at /dashboard/panel/edit/2/ correctly rendered in the web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15345

Differential Revision: https://we.phorge.it/D25189

Details

Provenance
Andre KlapperAuthored on May 5 2023, 5:53 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPf4d28119e849: Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled
Branches
Unknown
Tags
Unknown

Event Timeline