HomePhorge

When a build is aborted, fail the buildable

Description

When a build is aborted, fail the buildable

Summary:
Ref T13054. Fixes T10746. Fixes T11154. This is really a one-line fix (include ABORTED in BuildEngine->updateBuildable()) but try to structure the code a little more clearly too and reduce (at least slightly) the number of random lists of status attributes spread throughout the codebase.

Also add a header tag for buildable status.

Test Plan: Aborted a build, saw buildable fail properly.

Subscribers: yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13054, T11154, T10746

Differential Revision: https://secure.phabricator.com/D19055

Details

Provenance
epriestleyAuthored on Feb 10 2018, 11:34 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPd47c5de9d0ae: Fix PHPMailer/SMTP configuration typo for legacy SMTP configurations
Branches
Unknown
Tags
Unknown

Event Timeline