HomePhorge

Use standard subscribers effects in Herald Adapter for revisions

Description

Use standard subscribers effects in Herald Adapter for revisions

Summary:
Ref T8455. Use standard effects for revisions, instead of a custom effect.

This fixes the major issue (conduit error) in T8455 because the standard effect now performs PHID type filtering.

This retains other behaviors (in particular: not re-CC'ing explicitly removed CCs).

Test Plan:

  • With a Herald rule that adds a mailing list as a CC, created a revision before the change and hit the error in T8455. After the change, saw correct behavior.
  • Wrote a normal Herald rule to add CCs and created a revision, saw it fire properly.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8455

Differential Revision: https://secure.phabricator.com/D13183

Details

Provenance
epriestleyAuthored on Jun 8 2015, 10:32 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP1e918eecfaab: Use standard subscribers effects in Herald Adapter for tasks
Branches
Unknown
Tags
Unknown

Event Timeline