HomePhorge

When proxying an "{image ...}" image fails, show the user an error message

Description

When proxying an "{image ...}" image fails, show the user an error message

Summary:
Depends on D19192. Ref T4190. Ref T13101. Instead of directly including the proxy endpoint with <img src="..." />, emit a placeholder and use AJAX to make the request. If the proxy fetch fails, replace the placeholder with an error message.

This isn't the most polished implementation imaginable, but it's much less mysterious about errors.

Test Plan: Used {image ...} for valid and invalid images, got images and useful error messages respectively.

Maniphest Tasks: T13101, T4190

Differential Revision: https://secure.phabricator.com/D19193

Details

Provenance
epriestleyAuthored on Mar 8 2018, 5:29 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP01bbd71b9683: Separate the "{img ...}" remarkup rule into separate parse and markup phases
Branches
Unknown
Tags
Unknown

Event Timeline