HomePhorge

Implement macros as audio sources

Description

Implement macros as audio sources

Summary:
Fixes T3887. Basically:

  • Macros with audio get passed to the audio-source behavior.
  • This keeps track of where they are relative to the viewport as the user scrolls.
    • When the user scrolls a "once" macro into view, and it reaches roughly the middle of the screen, we play the sound.
    • When the user scrolls near a "loop" macro, we start playing the sound at low volume and increase the volume as the user scrolls.

This feels pretty good on both counts.

Test Plan: Tested in Safari, Chrome, and Firefox. FF seems a bit less responsive and doesn't support MP3, but it was fairly nice in Chrome/Safari.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3887

Differential Revision: https://secure.phabricator.com/D7160

Details

Provenance
epriestleyAuthored on Sep 27 2013, 4:02 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP7091dad606df: Allow macros to have associated audio and audio behaviors
Branches
Unknown
Tags
Unknown

Event Timeline