Change hard-coded PHID types to constants.
9bc04fe03dfe
Actions

Description

Change hard-coded PHID types to constants.

Summary:
add a constants module
src/applications/phid/constants/PhabricatorPHIDConstants.

Test Plan:
Execute applications which were using the hard-coded string.

Differential Revision: 44
Reviewed By: epriestley
Reviewers: epriestley
CC: epriestley

Details

Provenance

jungejason	Authored on Mar 2 2011, 6:58 PM
themackabu	Pushed on Mar 25 2025, 8:07 PM

Parents

rP2f3d98b24bb8: Further OAuth modularization.

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (38)

Path

Size

src/

__phutil_library_map__.php

applications/

differential/

controller/

attach/

DifferentialAttachController.php

__init__.php

revisionview/

DifferentialRevisionViewController.php

__init__.php

storage/

revision/

DifferentialRevision.php

__init__.php

files/

storage/

file/

PhabricatorFile.php

__init__.php

maniphest/

controller/

taskdetail/

ManiphestTaskDetailController.php

__init__.php

taskselectorsearch/

ManiphestTaskSelectorSearchController.php

__init__.php

transactionsave/

ManiphestTransactionSaveController.php

__init__.php

storage/

task/

ManiphestTask.php

__init__.php

view/

transactiondetail/

ManiphestTransactionDetailView.php

__init__.php

metamta/

storage/

mailinglist/

PhabricatorMetaMTAMailingList.php

__init__.php

people/

storage/

user/

PhabricatorUser.php

__init__.php

phid/

constants

handle/

PhabricatorObjectHandle.php

__init__.php

data/

PhabricatorObjectHandleData.php

__init__.php

project/

storage/

project/

PhabricatorProject.php

__init__.php

search/

controller/

search/

PhabricatorSearchController.php

__init__.php

index/

indexer/

differential/

PhabricatorSearchDifferentialIndexer.php

__init__.php

maniphest/

PhabricatorSearchManiphestIndexer.php

__init__.php

	applications/	phid/	constants/
	aphront/	response/	400/

	PhabricatorPHIDConstants.php
	Aphront400Response.php

	applications/	phid/	constants/
		aphront/	controller/

__init__.php

rP9bc04fe03dfe

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/controller/attach/DifferentialAttachController.php

View Options

src/applications/differential/controller/attach/init.php

View Options

src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php

View Options

src/applications/differential/controller/revisionview/init.php

View Options

src/applications/differential/storage/revision/DifferentialRevision.php

View Options

src/applications/differential/storage/revision/init.php

View Options

src/applications/files/storage/file/PhabricatorFile.php

View Options

src/applications/files/storage/file/init.php

View Options

src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php

View Options

src/applications/maniphest/controller/taskdetail/init.php

View Options

src/applications/maniphest/controller/taskselectorsearch/ManiphestTaskSelectorSearchController.php

View Options

src/applications/maniphest/controller/taskselectorsearch/init.php

View Options

src/applications/maniphest/controller/transactionsave/ManiphestTransactionSaveController.php

View Options

src/applications/maniphest/controller/transactionsave/init.php

View Options

src/applications/maniphest/storage/task/ManiphestTask.php

View Options

src/applications/maniphest/storage/task/init.php

View Options

src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php

View Options

src/applications/maniphest/view/transactiondetail/init.php

View Options

src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php

View Options

src/applications/metamta/storage/mailinglist/init.php

View Options

src/applications/people/storage/user/PhabricatorUser.php

View Options

src/applications/people/storage/user/init.php

View Options

src/applications/phid/constants/PhabricatorPHIDConstants.php

View Options

src/applications/phid/constants/init.php

View Options

src/applications/phid/handle/PhabricatorObjectHandle.php

View Options

src/applications/phid/handle/init.php

View Options

src/applications/phid/handle/data/PhabricatorObjectHandleData.php

View Options

src/applications/phid/handle/data/init.php

View Options

src/applications/project/storage/project/PhabricatorProject.php

View Options

src/applications/project/storage/project/init.php

View Options

src/applications/search/controller/search/PhabricatorSearchController.php

View Options

src/applications/search/controller/search/init.php

View Options

src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php

View Options

src/applications/search/index/indexer/differential/init.php

View Options

src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php

View Options

src/applications/search/index/indexer/maniphest/init.php

Change hard-coded PHID types to constants.9bc04fe03dfeActions

Description

Details

Event Timeline

Changes (38)

rP9bc04fe03dfe

src/__phutil_library_map__.php

src/applications/differential/controller/attach/DifferentialAttachController.php

src/applications/differential/controller/attach/__init__.php

src/applications/differential/controller/revisionview/DifferentialRevisionViewController.php

src/applications/differential/controller/revisionview/__init__.php

src/applications/differential/storage/revision/DifferentialRevision.php

src/applications/differential/storage/revision/__init__.php

src/applications/files/storage/file/PhabricatorFile.php

src/applications/files/storage/file/__init__.php

src/applications/maniphest/controller/taskdetail/ManiphestTaskDetailController.php

src/applications/maniphest/controller/taskdetail/__init__.php

src/applications/maniphest/controller/taskselectorsearch/ManiphestTaskSelectorSearchController.php

src/applications/maniphest/controller/taskselectorsearch/__init__.php

src/applications/maniphest/controller/transactionsave/ManiphestTransactionSaveController.php

src/applications/maniphest/controller/transactionsave/__init__.php

src/applications/maniphest/storage/task/ManiphestTask.php

src/applications/maniphest/storage/task/__init__.php

src/applications/maniphest/view/transactiondetail/ManiphestTransactionDetailView.php

src/applications/maniphest/view/transactiondetail/__init__.php

src/applications/metamta/storage/mailinglist/PhabricatorMetaMTAMailingList.php

src/applications/metamta/storage/mailinglist/__init__.php

src/applications/people/storage/user/PhabricatorUser.php

src/applications/people/storage/user/__init__.php

src/applications/phid/constants/PhabricatorPHIDConstants.php

src/applications/phid/constants/__init__.php

src/applications/phid/handle/PhabricatorObjectHandle.php

src/applications/phid/handle/__init__.php

src/applications/phid/handle/data/PhabricatorObjectHandleData.php

src/applications/phid/handle/data/__init__.php

src/applications/project/storage/project/PhabricatorProject.php

src/applications/project/storage/project/__init__.php

src/applications/search/controller/search/PhabricatorSearchController.php

src/applications/search/controller/search/__init__.php

src/applications/search/index/indexer/differential/PhabricatorSearchDifferentialIndexer.php

src/applications/search/index/indexer/differential/__init__.php

src/applications/search/index/indexer/maniphest/PhabricatorSearchManiphestIndexer.php

src/applications/search/index/indexer/maniphest/__init__.php

Change hard-coded PHID types to constants.
9bc04fe03dfe
Actions

src/applications/differential/controller/attach/init.php

src/applications/differential/controller/revisionview/init.php

src/applications/differential/storage/revision/init.php

src/applications/files/storage/file/init.php

src/applications/maniphest/controller/taskdetail/init.php

src/applications/maniphest/controller/taskselectorsearch/init.php

src/applications/maniphest/controller/transactionsave/init.php

src/applications/maniphest/storage/task/init.php

src/applications/maniphest/view/transactiondetail/init.php

src/applications/metamta/storage/mailinglist/init.php

src/applications/people/storage/user/init.php

src/applications/phid/constants/init.php

src/applications/phid/handle/init.php

src/applications/phid/handle/data/init.php

src/applications/project/storage/project/init.php

src/applications/search/controller/search/init.php

src/applications/search/index/indexer/differential/init.php

src/applications/search/index/indexer/maniphest/init.php