HomePhorge

Improve unhandled exception dialogs

Description

Improve unhandled exception dialogs

Summary:
Make the unhandled exception dialogs slightly more useful:

  • Make them easier to read.
  • Link to files from Phabricator libraries.
  • Don't show traces by default.
  • Show traces in development mode.
  • Rename button from "Cancel" to "Close" and only show it for Ajax.

Test Plan: Rigged DirectoryHomeController to throw, loaded home page. Changed
stack trace setting in config. Clicked some files in the trace.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen, codeblock
CC: aran, epriestley
Differential Revision: 823

Details

Provenance
epriestleyAuthored on Aug 17 2011, 2:29 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPb291ad980726: Unguard thumbnail generation from CSRF.
Branches
Unknown
Tags
Unknown

Event Timeline