Make Oauth-registration flows a bit more resilient to failures from the…
8988667dccee
Actions

Description

Make Oauth-registration flows a bit more resilient to failures from the providers

Summary: basically by validating we have good user data when we set the user data.

Test Plan: simulated a failure from a phabricator on phabricator oauth scenario. viewed ui that correctly told me there was an error with the provider and to try again.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T1077

Differential Revision: https://secure.phabricator.com/D2337

Details

Provenance

Bob Trahan	Authored on May 1 2012, 2:51 AM
themackabu	Pushed on Mar 25 2025, 8:07 PM

Parents

rP458563c68a27: Phame - use post title for the actual web page title

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (14)

Path

Size

src/

__phutil_library_map__.php

applications/

auth/

controller/

oauth/

PhabricatorOAuthLoginController.php

oauth/

provider/

base/

PhabricatorOAuthProvider.php

__init__.php

exception

facebook/

PhabricatorOAuthProviderFacebook.php

github/

PhabricatorOAuthProviderGitHub.php

google/

PhabricatorOAuthProviderGoogle.php

__init__.php

phabricator/

PhabricatorOAuthProviderPhabricator.php

__init__.php

	auth/	oauth/	provider/	exception/
		chatlog/	constants/	base/

	PhabricatorOAuthProviderException.php
	PhabricatorChatLogConstants.php

people/

controller/

settings/

panels/

oauth/

PhabricatorUserOAuthSettingsPanelController.php

	applications/	auth/	oauth/	provider/	exception/
			aphront/	exception/	base/

__init__.php

rP8988667dccee

View Options

src/__phutil_library_map__.php

View Options

src/applications/auth/controller/oauth/PhabricatorOAuthLoginController.php

View Options

src/applications/auth/oauth/provider/base/PhabricatorOAuthProvider.php

View Options

src/applications/auth/oauth/provider/base/init.php

View Options

src/applications/auth/oauth/provider/exception/PhabricatorOAuthProviderException.php

View Options

src/applications/auth/oauth/provider/exception/init.php

View Options

src/applications/auth/oauth/provider/facebook/PhabricatorOAuthProviderFacebook.php

View Options

src/applications/auth/oauth/provider/github/PhabricatorOAuthProviderGitHub.php

View Options

src/applications/auth/oauth/provider/google/PhabricatorOAuthProviderGoogle.php

View Options

src/applications/auth/oauth/provider/google/init.php

View Options

src/applications/auth/oauth/provider/phabricator/PhabricatorOAuthProviderPhabricator.php

View Options

src/applications/auth/oauth/provider/phabricator/init.php

View Options

src/applications/people/controller/settings/panels/oauth/PhabricatorUserOAuthSettingsPanelController.php

Make Oauth-registration flows a bit more resilient to failures from the…8988667dcceeActions

Description

Details

Event Timeline

Changes (14)

rP8988667dccee

src/__phutil_library_map__.php

src/applications/auth/controller/oauth/PhabricatorOAuthLoginController.php

src/applications/auth/oauth/provider/base/PhabricatorOAuthProvider.php

src/applications/auth/oauth/provider/base/__init__.php

src/applications/auth/oauth/provider/exception/PhabricatorOAuthProviderException.php

src/applications/auth/oauth/provider/exception/__init__.php

src/applications/auth/oauth/provider/facebook/PhabricatorOAuthProviderFacebook.php

src/applications/auth/oauth/provider/github/PhabricatorOAuthProviderGitHub.php

src/applications/auth/oauth/provider/google/PhabricatorOAuthProviderGoogle.php

src/applications/auth/oauth/provider/google/__init__.php

src/applications/auth/oauth/provider/phabricator/PhabricatorOAuthProviderPhabricator.php

src/applications/auth/oauth/provider/phabricator/__init__.php

src/applications/people/controller/settings/panels/oauth/PhabricatorUserOAuthSettingsPanelController.php

Make Oauth-registration flows a bit more resilient to failures from the…
8988667dccee
Actions

src/applications/auth/oauth/provider/base/init.php

src/applications/auth/oauth/provider/exception/init.php

src/applications/auth/oauth/provider/google/init.php

src/applications/auth/oauth/provider/phabricator/init.php