Improve remarkup codeblock syntax highlighting when using Dark Mode
Summary:
PhabricatorDefaultSyntaxStyle works now with 'CSS-color-aliases' instead of fixed colors.
The aliases are translated in the corresponding themes CelerityPostprocessor.
| Before | After |
|---|---|
| {F709419} | {F709421} |
Ref T15056
Test Plan:
- bin/celerity syntax
- bin/celerity map
- bin/cache purge --all
- sign in
- go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
- go to Phriction or Maniphest and add a codeblock.
Example:
<?php final class Example extends PhabricatorApplication { }
- verify that codeblock content is readable
- also check that with/without this, nothing changes in "normal" theme
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T15056
Differential Revision: https://we.phorge.it/D25509