HomePhorge

Fix a "setExternalURI()" fatal while browsing directories with submodules

Description

Fix a "setExternalURI()" fatal while browsing directories with submodules

Summary:
Ref T13595. See that task for discussion.

D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it.

Test Plan:

  • In Diffusion, browsed a directory with a submodule.
    • Before: "setExternalURI()" fatal in conduit call.
    • After: directory listing including submodule.

Maniphest Tasks: T13595

Differential Revision: https://secure.phabricator.com/D21520

Details

Provenance
epriestleyAuthored on Jan 26 2021, 8:39 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPbafe8d1bbdb2: Correct Git repository browse behavior for differences in "ls-tree" output
Branches
Unknown
Tags
Unknown

Event Timeline