HomePhorge

Fix GitHub OAuth Registration for users without a name

Description

Fix GitHub OAuth Registration for users without a name

Summary:
Github allows you to have an account without a real name. The OAuth controller
actually handles this fine, mostly, except that it calls a bogus method. Also
there is some null vs empty string confusion.

Test Plan:
Deleted my name on Github and then registered for an account on Phabricator.

Reviewed By: tuomaspelkonen
Reviewers: jungejason, tuomaspelkonen, aran
CC: anjali, aran, tuomaspelkonen
Differential Revision: 247

Details

Provenance
epriestleyAuthored on May 6 2011, 5:01 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4e70c434fdae: Fix Maniphest fatal when editing a task without changing anything
Branches
Unknown
Tags
Unknown

Event Timeline