HomePhorge

Fix XSS hole in inline comment editing

Description

Fix XSS hole in inline comment editing

Summary:
Thanks to erling for the report. This was XSSable, although you could
only get yourself.

Test Plan:
Made a comment like "</textarea><h1>" and edited it before and after
the patch. Proper behavior with this patch.

Reviewed By: aran
Reviewers: erling, jungejason, tuomaspelkonen, aran
CC: aran
Differential Revision: 187

Details

Provenance
epriestleyAuthored on Apr 29 2011, 8:18 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP78d33b177115: Silence an undeclared variable warning
Branches
Unknown
Tags
Unknown

Event Timeline