HomePhorge

Provide more information to users during `git push` while waiting for write…

Description

Provide more information to users during git push while waiting for write locks

Summary:
Ref T13109. Make it slightly more clear what the scope of the write and read locks are, and slightly more clear that we're actively acquiring locks, not just sitting around waiting.

While waiting on another writer, show who we're waiting on so you can walk over to their desk and glare at them.

Test Plan:
Added sleep(15) after willWrite(). Pushed in two windows. Saw new, more informative messages. In the second window, saw the new guidance:

  1. Waiting for hector to finish writing (on device "repo1.local.phacility.net" for 11s)...

Reviewers: asherkin

Reviewed By: asherkin

Subscribers: asherkin

Maniphest Tasks: T13109

Differential Revision: https://secure.phabricator.com/D19247

Details

Provenance
epriestleyAuthored on Mar 21 2018, 5:51 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPc8583b016daf: When workflow dialog buttons are clicked, disable the button
Branches
Unknown
Tags
Unknown

Event Timeline