HomePhorge

Diffusion - move commit parents query to conduit

Description

Diffusion - move commit parents query to conduit

Summary:
Ref T2784. Relatively complicated one as this bad boy is used in a repository daemon.

While testing, I noticed bugs in the expandshortname query stuff. Those variables are private to the parent class so they need some setX love.

Also, was unable to find links to the "before" stuff, but made them by hand by looking at some of these T2784 diffs, browsing a file at a specific revision, then hacking the "before" variable to be some known commit that also touched the file. This produced sensical results. On the process of doing that I upgraded a query to use the proper policy query.

Test Plan: In git, mercurial, svn, verified on a commit page the "parents" showed up correctly. played around with ?before parameter on specific file browse page, with commits known to have interesting history and stuff looked good

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2784

Differential Revision: https://secure.phabricator.com/D5988

Details

Provenance
Bob TrahanAuthored on May 21 2013, 4:22 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP6958f7677d61: Clean up some pht's in Projects
Branches
Loading...
Tags
Loading...

Event Timeline