HomePhorge

Make CelerityController extend PhabricatorController

Description

Make CelerityController extend PhabricatorController

Summary:
Currently, CelerityController extends AphrontController, not PhabricatorController. (I think I imagined Celerity being somewhat stand-alone and didn't want to create a dependency.)

This creates a concrete problem if a static resource is missing, since we throw an exception, but the higher-level exception handlers depend on the User existing in order to show an appropriate response page. This is the only controller which doesn't extend PhabricatorController, and it doesn't seem worthwhile to make a weird edge case out of it.

Specific repro case is:

  • Remove externals/javelin/ (or forget to run git submodule update --init).
  • Load a static resource.
  • Get "[Rendering Exception] Argument 1 passed to PhabricatorMainMenuView::setUser() must be an instance of PhabricatorUser, null given, called in /services/apache/phabricator/phabricator/src/view/page/PhabricatorStandardPageView.php on line 435 and defined"

Test Plan:

  • Followed above steps, no more fataling.
  • Verified this is the only weird controller.

Reviewers: voldern, vrana, btrahan

Reviewed By: voldern

CC: aran

Differential Revision: https://secure.phabricator.com/D3389

Details

Provenance
epriestleyAuthored on Aug 28 2012, 1:46 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPbc6aa910593f: Fix for search URL for ponder-related search results.
Branches
Unknown
Tags
Unknown

Event Timeline