HomePhorge

Move the "Can Lock Projects" check from requireCapabilities() to transaction…

Description

Move the "Can Lock Projects" check from requireCapabilities() to transaction validation

Summary: Depends on D19584. Ref T13164. This check is an extra check: you need EDIT and this capability. Thus, we can do it in validation without issues.

Test Plan:

  • This code isn't reachable today: all methods of applying this transaction do a separate check for "Can Lock" upfront.
  • Commented out the "Can Lock" check in the LockController, tried to lock as a user without permission. Was rejected with a policy exception.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13164

Differential Revision: https://secure.phabricator.com/D19585

Details

Provenance
epriestleyAuthored on Aug 14 2018, 2:46 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP3b92da22f433: Move the hierarchical edit policy check in Phriction from requireCapabilities()…
Branches
Loading...
Tags
Loading...

Event Timeline