Paths

Table of Contentst

Migrate Differential revision edges to use modern `EdgeType` subclasses
7cab903943f5
Actions

Description

Migrate Differential revision edges to use modern EdgeType subclasses

Summary: Modernize Differential edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan: From previous experience, these changes are fairly trivial and safe. I poked around a little to make sure things looked reasonably okay.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, Krenair, epriestley

Differential Revision: https://secure.phabricator.com/D11074

Details

Provenance

Joshua Spence	Authored on Dec 31 2014, 7:43 PM
themackabu	Pushed on Mar 25 2025, 8:07 PM

Parents

rPc564a3c22a65: Fix method name

Branches

Unknown

Tags

Unknown

Event Timeline

Changes (31)

Path

Size

resources/

sql/

autopatches/

20140212.dx.1.armageddon.php

20140420.rel.2.objectmig.php

patches/

20130409.commitdrev.php

20131004.dxreviewers.php

migrate-differential-dependencies.php

src/

__phutil_library_map__.php

applications/

differential/

controller/

DifferentialCommentPreviewController.php

DifferentialCommentSaveController.php

customfield/

DifferentialDependenciesField.php

DifferentialDependsOnField.php

DifferentialReviewersField.php

edge/

DifferentialReviewerForRevisionEdgeType.php

editor/

DifferentialTransactionEditor.php

query/

DifferentialRevisionQuery.php

storage/

DifferentialRevision.php

DifferentialTransaction.php

	differential/	edge/
	ponder/	edge/

	DifferentialRevisionDependedOnByRevisionEdgeType.php
	PonderVotingUserHasQuestionEdgeType.php

	differential/	edge/
	maniphest/	edge/

	DifferentialRevisionDependsOnRevisionEdgeType.php
	ManiphestTaskDependsOnTaskEdgeType.php

	DifferentialRevisionHasCommitEdgeType.php
	ManiphestTaskHasCommitEdgeType.php

	differential/	edge/
	diffusion/	edge/

	DifferentialRevisionHasReviewerEdgeType.php
	DiffusionCommitHasTaskEdgeType.php

diffusion/

controller/

DiffusionCommitController.php

edge/

DiffusionCommitHasRevisionEdgeType.php

events/

DiffusionHovercardEventListener.php

maniphest/

controller/

ManiphestTaskDetailController.php

edge/

ManiphestTaskDependedOnByTaskEdgeType.php

releeph/

commitfinder/

ReleephCommitFinder.php

field/

specification/

ReleephDependsOnFieldSpecification.php

repository/

worker/

commitmessageparser/

PhabricatorRepositoryCommitMessageParserWorker.php

search/

controller/

PhabricatorSearchAttachController.php

infrastructure/

edges/

constants/

PhabricatorEdgeConfig.php

internationalization/

translation/

PhabricatorBaseEnglishTranslation.php

rP7cab903943f5

View Options

resources/sql/autopatches/20140212.dx.1.armageddon.php

View Options

resources/sql/autopatches/20140420.rel.2.objectmig.php

View Options

resources/sql/patches/20130409.commitdrev.php

View Options

resources/sql/patches/20131004.dxreviewers.php

View Options

resources/sql/patches/migrate-differential-dependencies.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/controller/DifferentialCommentPreviewController.php

View Options

src/applications/differential/controller/DifferentialCommentSaveController.php

View Options

src/applications/differential/customfield/DifferentialDependenciesField.php

View Options

src/applications/differential/customfield/DifferentialDependsOnField.php

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

View Options

src/applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php

View Options

src/applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php

View Options

src/applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php

View Options

src/applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php

View Options

src/applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

View Options

src/applications/differential/query/DifferentialRevisionQuery.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/differential/storage/DifferentialTransaction.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php

View Options

src/applications/diffusion/events/DiffusionHovercardEventListener.php

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

View Options

src/applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php

View Options

src/applications/releeph/commitfinder/ReleephCommitFinder.php

View Options

src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php

View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

View Options

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Migrate Differential revision edges to use modern `EdgeType` subclasses7cab903943f5Actions

Description

Details

Event Timeline

Changes (31)

rP7cab903943f5

resources/sql/autopatches/20140212.dx.1.armageddon.php

resources/sql/autopatches/20140420.rel.2.objectmig.php

resources/sql/patches/20130409.commitdrev.php

resources/sql/patches/20131004.dxreviewers.php

resources/sql/patches/migrate-differential-dependencies.php

src/__phutil_library_map__.php

src/applications/differential/controller/DifferentialCommentPreviewController.php

src/applications/differential/controller/DifferentialCommentSaveController.php

src/applications/differential/customfield/DifferentialDependenciesField.php

src/applications/differential/customfield/DifferentialDependsOnField.php

src/applications/differential/customfield/DifferentialReviewersField.php

src/applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php

src/applications/differential/edge/DifferentialRevisionDependedOnByRevisionEdgeType.php

src/applications/differential/edge/DifferentialRevisionDependsOnRevisionEdgeType.php

src/applications/differential/edge/DifferentialRevisionHasCommitEdgeType.php

src/applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php

src/applications/differential/editor/DifferentialTransactionEditor.php

src/applications/differential/query/DifferentialRevisionQuery.php

src/applications/differential/storage/DifferentialRevision.php

src/applications/differential/storage/DifferentialTransaction.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/edge/DiffusionCommitHasRevisionEdgeType.php

src/applications/diffusion/events/DiffusionHovercardEventListener.php

src/applications/maniphest/controller/ManiphestTaskDetailController.php

src/applications/maniphest/edge/ManiphestTaskDependedOnByTaskEdgeType.php

src/applications/releeph/commitfinder/ReleephCommitFinder.php

src/applications/releeph/field/specification/ReleephDependsOnFieldSpecification.php

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

src/applications/search/controller/PhabricatorSearchAttachController.php

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Migrate Differential revision edges to use modern `EdgeType` subclasses
7cab903943f5
Actions