HomePhorge

Declare common Lisk properties

Description

Declare common Lisk properties

Summary:
Calling ->setPHID() or other common Lisk setters creates an implicit public property $phid.
I don't like implicit properties and I see them as errors.
Its public visibility also makes me nervous and is vulnerable to bypassing any setters we may create.

Test Plan: Loaded homepage, checked log.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3600

Details

Provenance
vranaAuthored on Oct 3 2012, 11:14 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP92aaffd0c572: Fix inconsistence in declared VS used property
Branches
Unknown
Tags
Unknown

Event Timeline