HomePhorge

Add a rate limit for enroll attempts when adding new MFA configurations

Description

Add a rate limit for enroll attempts when adding new MFA configurations

Summary:
Depends on D20018. Ref T13222. When you add a new MFA configuration, you can technically (?) guess your way through it with brute force. It's not clear why this would ever really be useful (if an attacker can get here and wants to add TOTP, they can just add TOTP!) but it's probably bad, so don't let users do it.

This limit is fairly generous because I don't think this actually part of any real attack, at least today with factors we're considering.

Test Plan:

  • Added TOTP, guessed wrong a ton of times, got rate limited.
  • Added TOTP, guessed right, got a TOTP factor configuration added to my account.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13222

Differential Revision: https://secure.phabricator.com/D20019

Details

Provenance
epriestleyAuthored on Jan 23 2019, 7:22 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPe91bc26da685: Don't rate limit users clicking "Wait Patiently" at an MFA gate even if they…
Branches
Loading...
Tags
Loading...

Event Timeline