HomePhorge

Throw CommandException instead of Exception after `git fetch` failure in…

Description

Throw CommandException instead of Exception after git fetch failure in repository updates

Summary: Fixes T9966. In this unusual, difficult-to-reach case, we throw Exception (which has no censoring) instead of CommandException (which has censoring). Throw CommandException instead.

Test Plan:

  • Hacked up a bunch of stuff in order to hit this: disabled origin validation, origin correction, and pointed repository at a bad domain.
  • Verified message is now censored correctly.

{F1022217}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9966

Differential Revision: https://secure.phabricator.com/D14745

Details

Provenance
epriestleyAuthored on Dec 11 2015, 4:48 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP4ec6990ca767: Implement a rough initial version of ApplicationSearch-driven Conduit read…
Branches
Unknown
Tags
Unknown

Event Timeline