HomePhorge

Enforce upload size limits and transport exceptions with appropriate response…

Description

Enforce upload size limits and transport exceptions with appropriate response encoding

Summary:

  • When a user uploads an oversized file, throw an exception.
  • When an uncaught exception occurs during a Conduit request, return a Conduit response.
  • When an uncaught exception occurs during a non-workflow Ajax request, return an Ajax response.

Test Plan:

  • Uploaded overlarge files.
  • Hit an exception page with ?ajax=1 and ?conduit=1

Reviewers: btrahan, vrana, jungejason

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T875, T788

Differential Revision: https://secure.phabricator.com/D2385

Details

Provenance
epriestleyAuthored on May 7 2012, 6:17 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rPb80ea9e0e85a: Revert cd63d9b2ce26 / D2403, see diff. This broke inline comments by making…
Branches
Unknown
Tags
Unknown

Event Timeline