HomePhorge

Extract textual object list parsing from Differential

Description

Extract textual object list parsing from Differential

Summary:
Ref T2222. Currently, Differential has a fairly hairy piece of logic to parse object lists, like Reviewers: alincoln, htaft. Extract, generalize, and cover this.

  • Some of the logic can be simplified with modern ObjectQuery stuff.
  • Make @username the formal monogram for users.
  • Make list@domain.com the formal monogram for mailing lists.
  • Add test coverage.

Test Plan:

  • Ran unit tests.
  • Called differential.parsecommitmessage with a bunch of real-world inputs and got sensible results.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8445

Details

Provenance
epriestleyAuthored on Mar 7 2014, 5:44 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPaff34077c52c: Move Differential commit message parsing to a separate, tested class
Branches
Unknown
Tags
Unknown

Event Timeline