HomePhorge

Limit the damage that degenerate project name typeahead queries can cause

Description

Limit the damage that degenerate project name typeahead queries can cause

Summary:
See PHI47. When users copy/paste a wall of text into a project tokenizer, we can end up performing a very large number of JOINs.

These JOINs seem okay locally and on secure, but the install in PHI47 reports hitting issues.

Since these queries are almost certainly illegitimate (I think no one uses 5+ words to find a project), just limit the search to the 5 longest tokens.

Note that typing 6 tokens will still almost always work, since the UI does additional filtering. However, if you have 100+ projects named "a b c d e ..." and search for "a b c d e z", you may not hit it. This is so degenerate that it's hard to imagine any users encountering it.

This is a stopgap fix, I'll file something longer-term as a followup.

Test Plan: Used /typeahead/class/PhabricatorProjectDatasource/ to run queries. Saw the same results with shorter query plans for all reasonable queries.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18506

Details

Provenance
epriestleyAuthored on Aug 30 2017, 11:08 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP11046d495dbf: Add a selected button ui state
Branches
Unknown
Tags
Unknown

Event Timeline