HomePhorge

Pull only existing authorPHIDs in blame

Description

Pull only existing authorPHIDs in blame

Summary:
I've hit this error by exhausting memory limit on blaming a big file with lots of unknown authors.
It triggered the error ~1000 times with stack trace containing the whole ~100 kB file.
The memory ran out when it tried to JSON serialize the stack traces for the DarkConsole.

Test Plan: Blamed file with unknown authors.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5730

Details

Provenance
Jakub VranaAuthored on Apr 18 2013, 8:20 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPd2874a96b8ef: DERP 2 with my last diff - shouldn't have pulled this outside the conditional
Branches
Unknown
Tags
Unknown

Event Timeline