HomePhorge

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Description

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Summary: This %d should be a %s, since the PhutilNumber value may get formatted according to locale settings.

Test Plan: will make @zeeg

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D8814

Details

Provenance
epriestleyAuthored on Apr 18 2014, 5:52 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP9889892e5b76: Actually squelch Harbormaster "test passed" mail
Branches
Unknown
Tags
Unknown

Event Timeline