HomePhorge

Allow users to add "ProfileMenu" items on mobile

Description

Allow users to add "ProfileMenu" items on mobile

Summary:
Depends on D20337. Fixes T12167. Ref T13272. On this page ("Favorites > Edit Favorites > Personal", for example) the curtain actions aren't available on mobile.

Normally, curtains are built with Controller->newCurtainView(), which sets an ID on the action list, which populates the header button. This curtain is built directly because there's no Controller handy.

To fix the issue, just set an ID. This could probably be cleaner, but that's likely a much more involved change.

Test Plan: Edited my favorites, narrowed the window, saw an "Actions" button.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13272, T12167

Differential Revision: https://secure.phabricator.com/D20338

Details

Provenance
epriestleyAuthored on Mar 27 2019, 2:09 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP6648942bc885: Don't allow "Conpherence" menu items to be added to editable menus if…
Branches
Unknown
Tags
Unknown

Event Timeline