HomePhorge

Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup

Description

Updated .arclint in Phorge to exclude package-lock.json from Aphlict setup

Summary:
Aphlict requires a machine generated package-lock.json that can trigger linters unnecessarily.

This revision excludes it from all linters

Test Plan:
Testing

Fake Change to set off the linter
diff --git a/support/aphlict/server/package-lock.json b/support/aphlict/server/package-lock.json
index 8af62ae233..a417725182 100644
--- a/support/aphlict/server/package-lock.json
+++ b/support/aphlict/server/package-lock.json
@@ -2,11 +2,12 @@
   "name": "aphlict-server",
   "requires": true,
   "lockfileVersion": 1,
+  "testing" : true,
   "dependencies": {
     "ws": {
       "version": "7.5.0",
       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
-      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgi4vw=="
+      "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
     }
   }
 }
arc lint results
root@63c842bff39e:/srv/phorge/phorge# arc lint
>>> Lint for support/aphlict/server/package-lock.json:

   Warning  (TXT3) Line Too Long
    This line is 156 characters long, but the convention is 80 characters.

               7     "ws": {
               8       "version": "7.5.0",
               9       "resolved": "https://registry.npmjs.org/ws/-/ws-7.5.0.tgz",
    >>>       10       "integrity": "sha512-6ezXvzOZupqKj4jUqbQ9tXuJNo+BR2gU8fFRk3XCP3e0G6WT414u5ELe6Y0vtp7kmSJ3F7YWObSNr1ESsgasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfi4vw=="
              11     }
              12   }
              13 }
root@63c842bff39e:/srv/phorge/phorge#

Updated change

Change to .arclint
diff --git a/.arclint b/.arclint
index f215d93fdc..ca89c601e4 100644
--- a/.arclint
+++ b/.arclint
@@ -2,7 +2,8 @@
   "exclude": [
     "(^externals/)",
     "(^webroot/rsrc/externals/(?!javelin/))",
-    "(/__tests__/data/)"
+    "(/__tests__/data/)",
+    "(^support/aphlict/server/package-lock.json)"
   ],
   "linters": {
     "chmod": {
arc lint results
root@63c842bff39e:/srv/phorge/phorge# arc lint
 OKAY  No lint messages.
root@63c842bff39e:/srv/phorge/phorge#

Reviewers: O1 Blessed Committers, deadalnix, eax, speck

Reviewed By: O1 Blessed Committers, deadalnix, eax, speck

Subscribers: speck, tobiaswiese

Maniphest Tasks: T15021

Differential Revision: https://we.phorge.it/D25012

Details

Provenance
ekubischtaAuthored on Jun 26 2021, 8:44 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rPe7740c8669b4: Add HarbormasterHookController as an entry point for all Harbormaster hooks
Branches
Unknown
Tags
Unknown

Event Timeline