HomePhorge

Description

Fix reticle

Summary:
Now I understand that behavior-edit-inline-comments.js:174-176 and DifferentialChangesetViewController.php:72-99 need to stay in sync:

  • 1 - isOnRight equals isNewFile
  • 1/-1 - left is new, right is missing
  • 1/2 - both are new

Test Plan: Hover inline comment.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Maniphest Tasks: T1076

Differential Revision: https://secure.phabricator.com/D2179

Details

Provenance
vranaAuthored on Apr 9 2012, 10:00 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP32f12d1f8fb7: Don't fatal when generating patch emails for diffs with binaries
Branches
Unknown
Tags
Unknown

Event Timeline